Re: [PATCH 7/8] pstore/ram: Make tracing log versioned

From: Anton Vorontsov
Date: Tue Jul 17 2012 - 14:11:23 EST

On Tue, Jul 17, 2012 at 09:56:01AM -0700, Greg Kroah-Hartman wrote:
> That's nice, but it breaks the build on my system as linux_banner
> somehow isn't enabled as part of the build?

I really don't see how you managed to disable it. :-)

init/version.c is built unconditionally, and it has
'const char linux_banner[]' unconditionally. Then ram.c includes
kernel.h, which unconditionally (well, under #ifdef __KERNEL__)
includes printk.h, which has 'extern const char linux_banner[];'

I'm still looking further, but can you please send your config
file? And may be gcc version?

p.s. While investigating this, I found that quite a lot of includes
are missing in pstore headers, and I was able to trigger at least
one issue. The patch will follow.

Anton Vorontsov
Email: cbouatmailru@xxxxxxxxx
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at