Re: [PATCH 7/8] pstore/ram: Make tracing log versioned

From: Greg Kroah-Hartman
Date: Tue Jul 17 2012 - 12:56:06 EST

On Mon, Jul 09, 2012 at 05:10:45PM -0700, Anton Vorontsov wrote:
> Decoding the binary trace w/ a different kernel might be troublesome
> since we convert addresses to symbols. For kernels with minimal changes,
> the mappings would probably match, but it's not guaranteed at all.
> (But still we could convert the addresses by hand, since we do print
> raw addresses.)
> If we use modules, the symbols could be loaded at different addresses
> from the previously booted kernel, and so this would also fail, but
> there's nothing we can do about it.
> Also, the binary data format that pstore/ram is using in its ringbuffer
> may change between the kernels, so here we too must ensure that we're
> running the same kernel.
> So, there are two questions really:
> 1. How to compute the unique kernel tag;
> 2. Where to store it.
> In this patch we're just passing linux_banner through CRC32.

That's nice, but it breaks the build on my system as linux_banner
somehow isn't enabled as part of the build?

Is there something else you can use? Or fix the build to work properly?

I'll take the previous patches in the series, but I obviously can't take
this one because of the build error, sorry.

greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at