Re: [RESEND PATCH 1/2] mfd: add irq domain support for max8997interrupts

From: Greg KH
Date: Tue Jul 17 2012 - 12:34:29 EST


On Mon, Jul 02, 2012 at 09:02:55AM +0900, Chanwoo Choi wrote:
> From: Thomas Abraham <thomas.abraham@xxxxxxxxxx>
>
> Add irq domain support for max8997 interrupts. The reverse mapping method
> used is linear mapping since the sub-drivers of max8997 such as regulator
> and charger drivers can use the max8997 irq_domain to get the linux irq
> number for max8997 interrupts. All uses of irq_base in platform data and
> max8997 driver private data are removed.
>
> Signed-off-by: Thomas Abraham <thomas.abraham@xxxxxxxxxx>
> Acked-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>
> Acked-by: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx>
> [Fix two bug which set max8997->irq_domain and correct wrong parameter]
> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
> arch/arm/mach-exynos/mach-nuri.c | 4 --
> arch/arm/mach-exynos/mach-origen.c | 1 -
> drivers/mfd/Kconfig | 1 +
> drivers/mfd/max8997-irq.c | 62 +++++++++++++++++++++--------------
> drivers/mfd/max8997.c | 1 -
> include/linux/mfd/max8997-private.h | 4 ++-
> include/linux/mfd/max8997.h | 1 -
> 7 files changed, 41 insertions(+), 33 deletions(-)

Once again, this patch breaks the build.

Please be more careful with your patches, and TEST THEM BEFORE SENDING
THEM OUT.

ugh,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/