Re: [PATCH 2/3] mm: fix possible incorrect return value ofmigrate_pages() syscall

From: Michal Nazarewicz
Date: Tue Jul 17 2012 - 09:02:30 EST

On Mon, 16 Jul 2012 19:59:18 +0200, JoonSoo Kim <js1304@xxxxxxxxx> wrote:

2012/7/17 Michal Nazarewicz <mina86@xxxxxxx>:
Joonsoo Kim <js1304@xxxxxxxxx> writes:
do_migrate_pages() can return the number of pages not migrated.
Because migrate_pages() syscall return this value directly,
migrate_pages() syscall may return the number of pages not migrated.
In fail case in migrate_pages() syscall, we should return error value.
So change err to -EIO

Additionally, Correct comment above do_migrate_pages()

Signed-off-by: Joonsoo Kim <js1304@xxxxxxxxx>
Cc: Sasha Levin <levinsasha928@xxxxxxxxx>
Cc: Christoph Lameter <cl@xxxxxxxxx>

Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>


When I resend with changing -EIO to -EBUSY,
could I include "Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>"?

Sure thing.

Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, MichaÅ âmina86â Nazarewicz (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at