Re: [Patch 7/7] infiniband: ehca: Use hotplug thread infrastructure

From: Rusty Russell
Date: Mon Jul 16 2012 - 21:07:54 EST


On Mon, 16 Jul 2012 10:42:39 -0000, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> + while (1) {
> + cpu = cpumask_next(pool->last_cpu, cpu_online_mask);
> + if (cpu >= nr_cpu_ids)
> + cpu = cpumask_first(cpu_online_mask);
> + pool->last_cpu = cpu;
> + /* Might be on the way out */
> + if (per_cpu_ptr(pool->cpu_comp_tasks, cpu)->active)
> + break;
> + }

I always look twice at while(1) loops; I'm sure there's a do-while
hiding in there.

Overall, the patch series looks like a very nice cleanup.

Thanks!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/