Re: [PATCH 1/3] mm: correct return value of migrate_pages()
From: JoonSoo Kim
Date: Mon Jul 16 2012 - 13:57:10 EST
2012/7/17 Michal Nazarewicz <mina86@xxxxxxx>:
> Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
> Actually, it makes me wonder if there is any code that uses this
> information. If not, it would be best in my opinion to make it return
> zero or negative error code, but that would have to be checked.
I think that, too.
I looked at every callsites for migrate_pages() and there is no place
which really need fail count.
This function sometimes makes caller error-prone,
so I think changing return value is preferable.
How do you think, Christoph?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/