Re: [PATCH 1/3] mm: correct return value of migrate_pages()
From: Christoph Lameter
Date: Mon Jul 16 2012 - 13:23:15 EST
On Tue, 17 Jul 2012, Joonsoo Kim wrote:
> migrate_pages() should return number of pages not migrated or error code.
> When unmap_and_move return -EAGAIN, outer loop is re-execution without
> initialising nr_failed. This makes nr_failed over-counted.
The itention of the nr_failed was only to give an indication as to how
many attempts where made. The failed pages where on a separate queue that
seems to have vanished.
> So this patch correct it by initialising nr_failed in outer loop.
Well yea it makes sense since retry is initialized there as well.
Acked-by: Christoph Lameter <cl@xxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/