Re: uprobes: fix uprobe tracer wrong documentation

From: Srikar Dronamraju
Date: Mon Jul 16 2012 - 07:17:12 EST


* Jovi Zhang <bookjovi@xxxxxxxxx> [2012-07-16 16:49:03]:

> From e382d2d14b8177bcd2e6bac2fee004fd1f052cb5 Mon Sep 17 00:00:00 2001
> From: Jovi Zhang <bookjovi@xxxxxxxxx>
> Date: Tue, 17 Jul 2012 00:35:30 +0800
> Subject: [PATCH] uprobes: fix uprobe tracer wrong documentation
>
> The uprobe example is wrong in current kernel:
> $ echo 'p: /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
> -bash: echo: write error: Invalid argument
>
> It should be as following:
> $ echo 'p /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events

Right, the colon is only needed if we want to provide the optional event
name.

>
> Signed-off-by: Jovi Zhang <bookjovi@xxxxxxxxx>

Acked-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>

> ---
> Documentation/trace/uprobetracer.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/trace/uprobetracer.txt
> b/Documentation/trace/uprobetracer.txt
> index 24ce682..8932726 100644
> --- a/Documentation/trace/uprobetracer.txt
> +++ b/Documentation/trace/uprobetracer.txt
> @@ -40,7 +40,7 @@ Usage examples
> To add a probe as a new event, write a new definition to uprobe_events
> as below.
>
> - echo 'p: /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
> + echo 'p /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
>
> This sets a uprobe at an offset of 0x4245c0 in the executable /bin/bash
>
> --
> 1.7.9.7

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/