Re: [PATCH] pinctrl: Add one-register-per-pin type device treebased pinctrl driver
From: Tony Lindgren
Date: Mon Jul 16 2012 - 03:10:27 EST
* Linus Walleij <linus.walleij@xxxxxxxxxx> [120714 13:21]:
> On Tue, Jul 10, 2012 at 11:11 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> > OK so no comments for a while. Here's the patch updated to leave out
> > the comments in the binding example.
> I reason like this:
> - My fears is that the code gets hopeless to understand the mux, the
> only way to understand that aspect of the system will be to read the DTS
> and have the data sheet ready at hand.
Yes that is a valid concern. Once we have the preprocessing available
for DTS files reading should be easier. Also user space tools can be
developed for showing the package specific data in detailed form.
> - Tony knows what he's doing and what is best for OMAP. And this gets
> (hopefully) all that OMAP mux code out of arch/arm.
Heh thanks for the positive feedback ;) Yes this should allow us to
drop close to 8k lines of data and code from arch/arm/mach-omap2
once the conversion is done. I'm planning to drop the unused entries
first to cut down the data quite a bit. And already omap5 and am33xx
are DT only and using pinctrl-single to start with. The remaining
legacy mux code can be dropped once we are done with the DT conversion.
> - Surely it will be better to go through this subsystem if we're refactoring
> it all again later, and all drivers can be transferred to the abstract
> pinctrl API which is a big win in itself, bringing coherency to the
> drivers/* at large.
> So applied it, so it can be evaluated in real operating environments.
> But if I don't see OMAP transferred to use this I'll simply delete it
> again. :-)
OK thanks, for reference some am33xx patches for beagle bone already
got posted using an earlier revision of this binding:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/