Re: [PATCH 4/5] gpio: tps6586x: add gpio support through platformdriver

From: Laxman Dewangan
Date: Mon Jul 16 2012 - 02:55:46 EST

On Sunday 15 July 2012 03:48 AM, Linus Walleij wrote:
On Fri, Jul 13, 2012 at 12:39 PM, Laxman Dewangan<ldewangan@xxxxxxxxxx> wrote:

Converting the gpio driver of tps6586x to a platform
driver in place of registering the gpio through core
The motivation of the change is:
- This is inline with the mfd drivers implementation.
- This will move the related gpio support to gpio driver
folder where all gpio related drivers are available.
This will be easy the maintenance and enhancement is
anything done for gpio.
- The gpio functionality can be selected through config

Signed-off-by: Laxman Dewangan<ldewangan@xxxxxxxxxx>
Overall this is very, very good and you're doing the right thing.

--- /dev/null
+++ b/drivers/gpio/gpio-tps6586x.c

Removed this inclusion as it is not require.

Reviewed-by: Linus Walleij<linus.walleij@xxxxxxxxxx>

I will add your reviewed-by in my next patch for easyness.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at