Re: [PATCH 6/6] staging: ccg: print MAC addresses via %pM

[Daniel Hazelton]

On 07/06/2012 11:32 AM, Kyungmin Park wrote:
> Acked-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>
> On Sat, Jul 7, 2012 at 12:28 AM, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>> Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>> ---
>>  drivers/staging/ccg/ccg.c |    8 ++------
>>  1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/staging/ccg/ccg.c b/drivers/staging/ccg/ccg.c
>> index a5b36a9..62f5d92 100644
>> --- a/drivers/staging/ccg/ccg.c
>> +++ b/drivers/staging/ccg/ccg.c
>> @@ -564,9 +564,7 @@ static int rndis_function_bind_config(struct ccg_usb_function *f,
>>                 return -1;
>>         }
>>
>> -       pr_info("%s MAC: %02X:%02X:%02X:%02X:%02X:%02X\n", __func__,
>> -               rndis->ethaddr[0], rndis->ethaddr[1], rndis->ethaddr[2],
>> -               rndis->ethaddr[3], rndis->ethaddr[4], rndis->ethaddr[5]);
>> +       pr_info("%s MAC: pM\n", __func__, rndis->ethaddr);
You lost a % there - it should be "%s MAC: %pM\n", no ?

DRH
>>
>>         ret = gether_setup_name(c->cdev->gadget, rndis->ethaddr, "rndis");
>>         if (ret) {
>> @@ -654,9 +652,7 @@ static ssize_t rndis_ethaddr_show(struct device *dev,
>>  {
>>         struct ccg_usb_function *f = dev_get_drvdata(dev);
>>         struct rndis_function_config *rndis = f->config;
>> -       return sprintf(buf, "%02x:%02x:%02x:%02x:%02x:%02x\n",
>> -               rndis->ethaddr[0], rndis->ethaddr[1], rndis->ethaddr[2],
>> -               rndis->ethaddr[3], rndis->ethaddr[4], rndis->ethaddr[5]);
>> +       return sprintf(buf, "%pM\n", rndis->ethaddr);
>>  }
>>
>>  static ssize_t rndis_ethaddr_store(struct device *dev,
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/