Re: [RFC][PATCH 02/26] mm, mpol: Remove NUMA_INTERLEAVE_HIT

[Minchan Kim]

Hi Hannes,

I alreay sent a patch about that but didn't have a reply from
Peter/Ingo.

https://lkml.org/lkml/2012/7/3/477

On Fri, Jul 06, 2012 at 12:32:55PM +0200, Johannes Weiner wrote:
> Hi Peter,
> 
> On Fri, Mar 16, 2012 at 03:40:30PM +0100, Peter Zijlstra wrote:
> > Since the NUMA_INTERLEAVE_HIT statistic is useless on its own; it wants
> > to be compared to either a total of interleave allocations or to a miss
> > count, remove it.
> > 
> > Fixing it would be possible, but since we've gone years without these
> > statistics I figure we can continue that way.
> > 
> > This cleans up some of the weird MPOL_INTERLEAVE allocation exceptions.
> > 
> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> > ---
> 
> > @@ -111,7 +111,6 @@ enum zone_stat_item {
> >  	NUMA_HIT,		/* allocated in intended node */
> >  	NUMA_MISS,		/* allocated in non intended node */
> >  	NUMA_FOREIGN,		/* was intended here, hit elsewhere */
> > -	NUMA_INTERLEAVE_HIT,	/* interleaver preferred this zone */
> >  	NUMA_LOCAL,		/* allocation from local node */
> >  	NUMA_OTHER,		/* allocation from other node */
> >  #endif
> 
> Can you guys include/fold this?
> 
> ---
> From: Johannes Weiner <hannes@xxxxxxxxxxx>
> Subject: [patch] mm: fix vmstat names-values off-by-one
> 
> "mm/mpol: Remove NUMA_INTERLEAVE_HIT" removed the NUMA_INTERLEAVE_HIT
> item from the zone_stat_item enum, but left the corresponding name
> string for it in the vmstat_text array.  As a result, all counters
> that follow it have their name offset by one from their value.
> 
> Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> ---
>  mm/vmstat.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index 1bbbbd9..e4db312 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -717,7 +717,6 @@ const char * const vmstat_text[] = {
>  	"numa_hit",
>  	"numa_miss",
>  	"numa_foreign",
> -	"numa_interleave",
>  	"numa_local",
>  	"numa_other",
>  #endif
> -- 
> 1.7.7.6
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/