Re: [PATCH 15/19] Staging: xgifb: Rework conditions in XGI_SetLockRegs().

From: Miguel Gómez
Date: Fri Jul 06 2012 - 04:12:08 EST


Hi!

On Thu, Jul 05, 2012 at 04:45:58PM +0200, Miguel Gómez wrote:
+ if ((pVBInfo->VBType & VB_SIS301LV) &&
+ !(pVBInfo->TVInfo & TVSetHiVision)) {
+ if ((pVBInfo->TVInfo & TVSimuMode) &&
+ (pVBInfo->TVInfo & TVSetPAL)) {
+ if (pVBInfo->VBType & VB_SIS301LV) {
+ if (!(pVBInfo->TVInfo &
+ (TVSetYPbPr525p |
+ TVSetYPbPr750p |
+ TVSetHiVision)))
+ tempbx += 40;
+ } else {
+ tempbx += 40;

I think this could be simplified even more - both branches end up doing
the same?!

I'll give it a look again :)

Regards!


--
Miguel Gómez
Igalia - http://www.igalia.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/