Re: [PATCH v2 2/2] ata: implement MODE SELECT command

From: Sergei Shtylyov
Date: Thu Jul 05 2012 - 15:43:59 EST


Hello.

On 07/05/2012 04:05 PM, Paolo Bonzini wrote:

>>> +
>>> + /*
>>> + * No mode subpages supported (yet) but asking for _all_
>>> + * subpages may be valid
>>> + */
>>> + if (spg && (spg != ALL_SUB_MPAGES))
>>> + goto invalid_param;

>> Rather "paramater not supported" (0x26/0x01)...

> SCSI spec begs to differ... there is no reference to that sense code in
> the whole SPC spec.

Right you are, I was just picking the more fitting ASC/ASCQ from the table
instead of reading the command description itself. :-<

MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/