Re: [PATCH] regulator: tps65910: add support for input supply

[Stephen Warren]

On 07/05/2012 08:03 AM, Laxman Dewangan wrote:
> There is multiple voltage input pins on device which
> takes the voltage input for different voltage regulator.
> Support to configure the voltage input supplied by
> different regulator for each regulators.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>

A couple nit-picky comments below:

> diff --git a/Documentation/devicetree/bindings/mfd/tps65910.txt b/Documentation/devicetree/bindings/mfd/tps65910.txt

> +- vin-xxx-supply: Input voltage supply regulator.

It'd be nice to name these simply xxx-supply; the "vin-" seems redundant.

> +  Missing of these properties will be assume as there is no parent regulator
> +  for that input pins and always powered on.
> +  The valid input supply properties are:
> +  tps65910:
> +	vin-vcc7-supply: VRTC input.
> +	vin-vccio-supply: VIO input.
> +	vin-vcc1-supply: VDD1 input.
> +	vin-vcc2-supply: VDD2 input.
> +	vin-vcc6-supply: VDIG1 and VDIG2 input.
> +	vin-vcc5-supply: VPLL and VDAC input.
> +	vin-vcc4-supply: VAUX1 and VAUX2 input.
> +	vin-vcc3-supply: VAUX33 and VMMC input.
> +  tps65911:
> +	vin-vcc7-supply: VRTC input.
> +	vin-vcc1-supply: VDD1 input.
> +	vin-vcc2-supply: VDD2 input.
> +	vin-vccio-supply: VIO input.
> +	vin-vcc6-supply: LDO1 and LDO2 input.
> +	vin-vcc5-supply: LDO3 and LDO4 input.
> +	vin-vcc4-supply: LDO5 input.
> +	vin-vcc3-supply: LDO6, LDO7 and LDO8 input.

It'd be nice to sort these lists of names so they appear in some
discernible order.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/