Re: [PATCH 2/3] perf, tool: Enable grouping logic for parsed events

[Namhyung Kim]

On Wed, 4 Jul 2012 19:34:07 +0200, Jiri Olsa wrote:
> On Tue, Jul 03, 2012 at 09:58:44AM +0900, Namhyung Kim wrote:
>> On Mon, 2 Jul 2012 12:10:10 +0200, Jiri Olsa wrote:
>> > On Mon, Jul 02, 2012 at 11:13:56AM +0900, Namhyung Kim wrote:
>> >> On Fri, 29 Jun 2012 11:08:26 +0200, Jiri Olsa wrote:
>> >> > It's possible to use standard event modifier for a group, which spans
>> >> > over all events in the group and overrides any event modifier settings,
>> >> > for example:
>> >> >
>> >> >   # perf record -r '{faults:k,cache-references}:u'
>> >> >
>> >> > resulting in ':u' modifier being used for both 'faults' and 'cache-references'
>> >> > events, regardless of their modifier setup (':k' for faults event).
>> >> >
>> >> 
>> >> So the faults event would get only 'u' for the modifier not 'uk', right?
>> >
>> > right
>> >
>> 
>> I was thinking about the combining the modifiers - i.e. make it 'uk'
>> above. Not sure it's useful in general, but something like "adding 'p'
>> to the leader (only)" looks good to have IMHO.
>
> just hit the issue with leader 'p' during tests ;) but still not sure which
> way is more usefull thought.. probably better to have both ways available
>
> how about uppercase group modifier overwrites, lowercase means combining
>
> or any other way.. ;) thoughts?
>

How about using like '{...}+u' for combining?

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/