RE: [PATCH] printk: fixing the deadlock when calling printk in nmihandle

From: Peter Zijlstra
Date: Wed Jul 04 2012 - 10:52:00 EST


On Wed, 2012-07-04 at 16:50 +0200, Peter Zijlstra wrote:
> On Wed, 2012-07-04 at 14:46 +0000, Liu, Chuansheng wrote:
> > > > I took many time to dig out this issue.
> > >
> > > Well, it was a known issue..
> > Still feel unfair :)
> > If this is a known issue that calling printk is not safe in nmi handler,
> > Why not defense it like this patch before real solution coming out?
>
> Why replace one broken thing with another broken thing?

Also, I much prefer obviously broken over subtly broken.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/