[PATCH] kernel: fix mishandling of out of memory in poweroff

From: Alan Cox
Date: Wed Jul 04 2012 - 10:36:02 EST


From: Alan Cox <alan@xxxxxxxxxxxxxxx>

Coverity 703573

Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
---

kernel/sys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sys.c b/kernel/sys.c
index b04ae03..9271b7c 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -2212,13 +2212,13 @@ int orderly_poweroff(bool force)

ret = call_usermodehelper_fns(argv[0], argv, envp, UMH_NO_WAIT,
NULL, argv_cleanup, NULL);
-out:
if (likely(!ret))
return 0;

if (ret == -ENOMEM)
argv_free(argv);

+out:
if (force) {
printk(KERN_WARNING "Failed to start orderly shutdown: "
"forcing the issue\n");

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/