Re: [PATCH 1/1 v2 ] ipmi: Setting OS name as Linux in BMC

From: Andi Kleen
Date: Wed Jul 04 2012 - 08:17:29 EST


> The intend of this patch was not to really workaround any issues, the aim was for the management software to use this data.

.. use it to do something "Linux" specific right?

I think Corey summed it up pretty well in his previous comment. Management software associated with BMC usually use this information to let the users know about the OS that is using the BMC. Generally there are 3rd party application software that goes and pretty much fills up the OS env information and the management software uses this. My intend was why don't we get this information loaded by the driver itself. If there are applications that wants to rewrite it, so be it..!
> Rather than just have a static entry such as 'Linux' I could probably write the version number and more(distro name etc.. )
>
> Thoughts.. ?

I still think "Linux" means nothing even to the management software.
What should it do with that?

If you provide some way for a distro to fill in "foobar linux 1.2.3.4"
maybe. But just Linux or even Linux x.y.z would be wrong because the same kernel
version can behave very differently.

But it would be better to define specific feature flags for
specific needs that actually mean something.

> I know there were some concerns with the security aspect, Can you please let me know what kind of security holes we could be looking at ?

I don't think there are any security problems. just forward/backward
compatibility problems, as the ACPI experience shows.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/