Re: [PATCH 08/10] perf, tool: Add sysfs read file interface

[Peter Zijlstra]

On Wed, 2012-07-04 at 00:00 +0200, Jiri Olsa wrote:
> +int sysfs_read_file(const char *file, char *buf, size_t size)
> +{
> +       char path[PATH_MAX];
> +       FILE *fp;
> +       int ret = 0;
> +
> +       snprintf(path, PATH_MAX, "%s/%s", sysfs_mountpoint, file);
> +
> +       fp = fopen(path, "r");
> +       if (!fp)
> +               return -errno;
> +
> +       if (fread(buf, 1, size, fp) == 0)
> +               ret = -errno;
> +
> +       fclose(fp);
> +       return ret; 

Does sysfs guarantee a single read is complete? If not, we need a while
loop around that read until EOF or size.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/