Re: [PATCH 04/10] perf, x86: Making hardware events translationsavailable in sysfs

[Peter Zijlstra]

On Wed, 2012-07-04 at 00:00 +0200, Jiri Olsa wrote:
> +#define PMU_EVENTS_ATTR_CONFIG(_name, _id)                             \
> +static ssize_t                                                         \
> +_name##_show(struct device *dev,                                       \
> +                          struct device_attribute *attr,               \
> +                          char *page)                                  \
> +{                                                                      \
> +       u64 val = x86_pmu.event_map(_id);                               \
> +       BUILD_BUG_ON(_id >= PERF_COUNT_HW_MAX);                         \
> +       return sprintf(page, "config=0x%llx\n", val);                   \
> +}                                                                      \ 

How about something like:

 u64 config = x86_pmu.event_map(_id);
 u64 event = (config & ARCH_PERFMON_EVENTSEL_EVENT) |
	     (config & AMD64_EVENTSEL_EVENT) >> 24;
 u64 umask = (config & ARCH_PERFMON_EVENTSEL_UMASK) >> 8;

 WARN_ON_ONCE(config & (ARCH_PERFMON_EVENTSEL_INV |
                        ARCH_PERFMON_EVENTSEL_CMASK));

 sprintf("event=0x%02llx,umask=0x%02llx\n", event, umask);




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/