RE: [PATCH v2 net-next 1/2] r8169: support RTL8106E

[hayeswang]

Francois Romieu [mailto:romieu@xxxxxxxxxxxxx] 
[...]
> > +#define FIRMWARE_8106E_1	"rtl_nic/rtl8106e-1.fw"
> 
> I did not notice it. Was it submitted ?
> 

I don't submit it yet.

> It was obviously not required for testing :o)
> 
> > @@ -1933,6 +1941,8 @@ static void 
> rtl8169_get_mac_version(struct rtl8169_private *tp,
> >  		{ 0x7c800000, 0x30000000,	RTL_GIGA_MAC_VER_11 },
> >  
> >  		/* 8101 family. */
> > +		{ 0x7cf00000, 0x44900000,	RTL_GIGA_MAC_VER_39 },
> > +		{ 0x7c800000, 0x44800000,	RTL_GIGA_MAC_VER_39 },
> >  		{ 0x7c800000, 0x44000000,	RTL_GIGA_MAC_VER_37 },
> >  		{ 0x7cf00000, 0x40b00000,	RTL_GIGA_MAC_VER_30 },
> >  		{ 0x7cf00000, 0x40a00000,	RTL_GIGA_MAC_VER_30 },
> 
> Realtek's 1.022.00 8101 driver only maps { 0x7c800000; 0x44800000 } to
> a generic device - if at all - and it maps { 0x7cf00000; 0x44800000 }
> to a different chipset (namely CFG_METHOD_15 where RTL_GIGA_MAC_VER_39
> is CFG_METHOD_16).
> 
> Why should both drivers diverge ?
> 

Our PMs say only 0x44900000 would have mass production. Besides, you could use
the same setting for both of them. 

Best Regards,
Hayes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/