Re: [PATCH] cgroup: cgroup_rm_files() was calling simple_unlink()with the wrong inode

From: Li Zefan
Date: Wed Jul 04 2012 - 01:44:19 EST


Tejun Heo wrote:

>>From 6da2689412c78b97716ec524cc30baf7b46508cd Mon Sep 17 00:00:00 2001
> From: Tejun Heo <tj@xxxxxxxxxx>
> Date: Tue, 3 Jul 2012 10:32:26 -0700
>
> While refactoring cgroup file removal path, 05ef1d7c4a "cgroup:
> introduce struct cfent" incorrectly changed the @dir argument of
> simple_unlink() to the inode of the file being deleted instead of that
> of the containing directory.
>
> The effect of this bug is minor - ctime and mtime of the parent
> weren't properly updated on file deletion.
>
> Fix it by using @cgrp->dentry->d_inode instead.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Reported-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>


Acked-By: Li Zefan <lizefan@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/