Re: [PATCH -mm] mm: minor fixes for compaction

[Minchan Kim]

On 07/04/2012 05:13 AM, Rik van Riel wrote:

> This patch makes the comment for cc->wrapped longer, explaining
> what is really going on. It also incorporates the comment fix
> pointed out by Minchan.
> 
> Additionally, Minchan found that, when no pages get isolated,
> high_pte could be a value that is much lower than desired,
> which might potentially cause compaction to skip a range of
> pages.
> 
> Only assign zone->compact_cache_free_pfn if we actually
> isolated free pages for compaction.
> 
> Signed-off-by: Rik van Riel <riel@xxxxxxxxxx>


Reviewed-by: Minchan Kim <minchan@xxxxxxxxxx>

> ---
> This does not address the one bit in Minchan's review that I am not sure about...


About this part, let's wait of Mel's opinion.

Thanks.
-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/