Re: long boot delays caused by 070ad7e7 floppy change

From: Jiri Kosina
Date: Tue Jul 03 2012 - 13:57:58 EST


On Tue, 3 Jul 2012, Linus Torvalds wrote:

> > Ok, here's the dmesg output that I get:
> >
> > [ 0.714316] floppy0: lock_fdc: -1 (out of 8)
>
> Ok, thanks. That -1 definitely explains the long delay. It's using
> "drive=-1" because it has no actual drive number, just the
> *controller* number.
>
> And the backtrace shows what's going on too: it's the
>
> user_reset_fdc(-1, FD_RESET_ALWAYS, false);
>
> that passes in -1 as the floppy controller number.
>
> Ugh.
>
> It looks like the code meant for -1 to mean "regular delay"
> (current_reqD), and -2 to mean MAXTIMEOUT. For some reason the "-1"
> logic has gotten screwed.

I am still trying to understand the exact situation.

Andi, do I understand you correctly that even if you revert 070ad7e793dc
on top of current Linus' tree, you are still seeing the 20 second delay
inside the initcall?

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/