Re: [PATCH 3/3] fs/sysv: stop using write_super and s_dirt

From: Artem Bityutskiy
Date: Tue Jul 03 2012 - 10:40:38 EST


On Tue, 2012-07-03 at 15:13 +0100, Alan Cox wrote:
> > drity and then setting the s_dirt flag. And when 'write_super()' is executed to
> > handle the s_dirt flag, we just update the timestamp and again mark the
> > superblock buffer as dirty. Seems pointless.
>
> It's the way sysv itself does stuff. The timestamp on v7/sys3/sys5
> reflects the clock on the box. A lot of ancient boxes with no decent
> hardware clocks used to reset the system time off the root fs superblock
> on a loss of power.

Oh, OK, thanks for the info. Do you think I need to take more efforts to
preserve the behavior?

--
Best Regards,
Artem Bityutskiy

Attachment: signature.asc
Description: This is a digitally signed message part