RE: [Xen-devel] [xen vMCE RFC V0.2] xen vMCE design

From: Jan Beulich
Date: Tue Jul 03 2012 - 03:15:47 EST


>>> On 02.07.12 at 19:32, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
> Thanks AMD's feedback :)
>
> This vMCE design foils is basically for Intel MCA, involving many details
> specific to Intel.
> I agree that for x86 Intel and AMD can share logic in many fields. However,
> for MCA logic Intel and AMD are quite different, like
> 1. MSRs interface, e.g. MCG_CAP, MCi_MICS, MCi_CTL2, etc;
> 2. error injection, AMD provide NMI/single MCE/broadcast MCE, while in our
> design only concern broadcast MCE# (and pretend to expose CMCI);
> 3. MCE handler: currently in xen Intel and AMD mce use different triggle
> method and mce handler;
>
> Considering the big difference, I suggest we separately provide Intel vMCE
> and AMD vMCE (i.e. vmce_intel.c and vmce_amd.c).

I'm not convinced of the need, and would prefer aiming at a
shared implementation unless issues arise that make this
impossible.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/