Re: [PATCH 2/2] Made core dump functionality optional

From: Cong Wang
Date: Tue Jul 03 2012 - 00:55:47 EST


On Tue, Jul 3, 2012 at 8:38 AM, Alex Kelly <alex.page.kelly@xxxxxxxxx> wrote:
> From: Alex <eshink@xxxxxxxxx>
>
> Adds an expert Kconfig option, CONFIG_COREDUMP, which allows disabling of core dump.
> This saves approximately 2.6k in the compiled kernel, and complements CONFIG_ELF_CORE,
> which now depends on it.
>
> CONFIG_COREDUMP also disables coredump-related sysctls, except for suid_dumpable and
> related functions, which are necessary for ptrace.
>
> Signed-off-by: Alex Kelly <alex.page.kelly@xxxxxxxxx>
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

Looks good, just one nitpick: would CONFIG_CORE_DUMP be better than
CONFIG_COREDUMP?

Reviewed-by: WANG Cong <xiyou.wangcong@xxxxxxxxx>

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/