Re: [PATCH] perf target: Ignore return value of strerror_r()explicitly

[Arnaldo Carvalho de Melo]

Em Mon, Jul 02, 2012 at 03:20:14PM +0900, Namhyung Kim escreveu:
> Since glibc 2.16 added the warn_unused_result (wur) attribute
> to the function, we should check the return value or ignore it
> explicitly.
> 
> Reported-by: Markus Trippelsdorf <markus@xxxxxxxxxxxxxxx>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>

> +++ b/tools/perf/util/target.c
> @@ -111,7 +111,8 @@ int perf_target__strerror(struct perf_target *target, int errnum,
>  	const char *msg;
>  
>  	if (errnum >= 0) {
> -		strerror_r(errnum, buf, buflen);
> +		/* make glibc (>= 2.16) happy */
> +		(void)strerror_r(errnum, buf, buflen);

Is this really the best way to handle this?

What if some perf tool is buggy and passes an invalid errnum?  Shouldn't
we catch that?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/