Re: [PATCH 2/2] ASoC: tegra: use sound pcm library for substream dmabuffer

From: Mark Brown
Date: Mon Jul 02 2012 - 05:56:04 EST


On Mon, Jul 02, 2012 at 11:14:55AM +0200, Takashi Iwai wrote:
> Laxman Dewangan wrote:

> > - if (!card->dev->dma_mask)
> > - card->dev->dma_mask = &tegra_dma_mask;
> > - if (!card->dev->coherent_dma_mask)
> > - card->dev->coherent_dma_mask = DMA_BIT_MASK(32);

> The mask setup is still required even if you use the preallocation
> helper.

Though that code is at least notionally buggy anyway, it should be the
DMA controller device that's used to obtain the DMA mask rather than the
card device which is basically unconnected with DMA.

Attachment: signature.asc
Description: Digital signature