Re: [PATCH] mmc: always save error codes in mmc_regulator_get_supply()

[Pankaj Jangra]

Hi,

On Wed, Jun 27, 2012 at 8:48 PM, Guennadi Liakhovetski
<g.liakhovetski@xxxxxx> wrote:
> If mmc_regulator_get_supply() fails to obtain any of the regulators, store
> the error codes in struct mmc_host to unify error reporting to the host
> driver.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> ---
>
> Chris, if you don't mind rebasing your mmc-next branch, feel free to roll
> this patch into the original "mmc: add a function to get regulators,
> supplying card's power". Otherwise, committing it as an incremental patch
> is also ok.
>
>  drivers/mmc/core/core.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index 385cadf..d0f17d8 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -1020,13 +1020,12 @@ int mmc_regulator_get_supply(struct mmc_host *mmc)
>         int ret;
>
>         supply = devm_regulator_get(dev, "vmmc");
> +       mmc->supply.vmmc = supply;
> +       mmc->supply.vqmmc = devm_regulator_get(dev, "vqmmc");
>
>         if (IS_ERR(supply))
>                 return PTR_ERR(supply);
>
> -       mmc->supply.vmmc = supply;
> -       mmc->supply.vqmmc = devm_regulator_get(dev, "vqmmc");
> -

I have a doubt here. Though  i am not much know to mmc code, but could
you please explain what is the benefit of moving these
statements above the error checking. I mean if you are not able to get
"vmmc" supply then why do you care to get the supply "vqmmc"
while by this error check you want to bail out from here ASAP and also
by doing this you are unnecessarily increasing the consumer
for "vqmmc" supply.  Please let me know if i am missing something here.

Also if you want to save the error code only you may want to move the
statement "mmc->supply.vmmc = supply"  only above the error
checking right?

>         ret = mmc_regulator_get_ocrmask(supply);
>         if (ret > 0)
>                 mmc->ocr_avail = ret;
> --

Regards,
Pankaj Jangra
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/