Re: [PATCH v2] regulator: fixed: support deferred probe for DT GPIOs

From: Mark Brown
Date: Sun Jul 01 2012 - 14:23:01 EST


On Fri, Jun 29, 2012 at 10:33:15AM -0600, Stephen Warren wrote:

> of_get_named_gpio() needs the driver hosting the GPIO that the DT
> property references to have been probed. Detect this specific failure,
> and defer the probe of the whole regulator until this API can complete.

I've applied this but...

> + /*
> + * of_get_named_gpio() currently returns ENODEV rather than
> + * EPROBE_DEFER. This code attempts to be compatible with both
> + * for now; the ENODEV check can be removed once the API is fixed.

...this just seems rubbish, why aren't we just fixing the device tree
code and why are we doing this at the device tree level rather than as a
general gpiolib thing?

Attachment: signature.asc
Description: Digital signature