Re: [PATCH] driver core: fix shutdown races with probe/remove(v2)

[Ming Lei]

On Fri, Jun 22, 2012 at 12:12 AM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 22 Jun 2012, Ming Lei wrote:
>
>> On Thu, Jun 21, 2012 at 9:49 PM, Greg Kroah-Hartman
>> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>>
>> > We also have not made the rule that a shutdown will complete in a
>> > specific amount of time either, so there is no problem if that takes a
>> > long time as well.
>>
>> OK, I will submit a new patch which just holds device lock.
>>
>> Alan, do you have objections on the new one?
>
> No objections.  It should end up being pretty much like one of the
> patches you posted earlier.

Holding parent reference count is missed in earlier version.

>
> Should there be an option for a debug log of each device name just
> before its shutdown routine is called?

We have had the below before calling shutdown callback.

          dev_dbg(dev, "shutdown\n");

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/