Re: linux-next: build failure after merge of the regulator tree
From: Stephen Rothwell
Date: Thu Jun 21 2012 - 07:04:24 EST
Hi Andrew,
On Thu, 21 Jun 2012 16:20:46 +0800 Axel Lin <axel.lin@xxxxxxxxx> wrote:
>
> 2012/6/21 Kim, Milo <Milo.Kim@xxxxxx>:
> >> Caused by commit 809d310c7e69 ("regulator: lp872x: Don't allow modular
> >> build") but that was done to fix a different build problem.
> >
> > Sorry for this conflict.
> >
> > Build config of lp872x driver has been changed as tristate.
> > And related undefined symbol error has been fixed.
> > (don't use devm_gpio_request_one() at this moment because it can not be exported.)
>
> I don't think this is the good way, other drivers may have this build problem.
> I think we can fix it by having the patch exporting
> devm_gpio_request_one upstrem ASAP.
>
> BTW, In yesterday's linux-next tree, Andrew has below commit.
>
> commit a291ede7be8359a8986740b11b93f9c80e40210b
> Author: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Date: Wed Jun 20 09:55:47 2012 +1000
>
> backlight-l4f00242t03-use-devm_gpio_request_one-fix
>
> export devm_gpio_request_one() to modules
>
> Cc: Alberto Panizzo <alberto@xxxxxxxxxxxxxxxxxxxx>
> Cc: Jingoo Han <jg1.han@xxxxxxxxxxx>
> Cc: Richard Purdie <rpurdie@xxxxxxxxx>
> Cc: Grant Likely <grant.likely@xxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
This export is needed for a patch in the regulator tree, so can we have
that patch sent to Linus ASAP, please?
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
Attachment:
pgp00000.pgp
Description: PGP signature