Re: [PATCH] regulator: arizona: Add support for microphone supplieson Arizona devices

From: Mark Brown
Date: Wed Jun 20 2012 - 07:48:49 EST


On Wed, Jun 20, 2012 at 07:32:18PM +0800, Axel Lin wrote:

> I think you may want to put this Kconfig entriy along with other
> Wolfson Microelectronics chips. So all Wolfson chips show in a group.

I'd rather keep the Kconfig entries sorted alphabetically.

> BTW, seems the MFD_ARIZONA patchs are not (yet) available in LKML.

Surprisingly I am aware of that...

> > +       if (selector < 0)
> > +               return -EINVAL;

> I think you don't need this checking. You already ensure min_uV >= 1700000.

No harm in being paranoid.

Attachment: signature.asc
Description: Digital signature