Re: [PATCH 3/3] uprobes: write_opcode()->__replace_page() can racewith try_to_unmap()

[Oleg Nesterov]

On 06/15, Ingo Molnar wrote:
>
> * Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx> wrote:
>
> > > @@ -228,9 +210,10 @@ static int write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm,
> > >  	void *vaddr_old, *vaddr_new;
> > >  	struct vm_area_struct *vma;
> > >  	struct uprobe *uprobe;
> > > +	unsigned long pgoff;
> > >  	loff_t addr;
> > >  	int ret;
> > > -
> > > +retry:
> >
> > Just a check on coding style: Shouldnt we have a preceeding blank
> > line before the goto label.
>
> Yeah, that's most likely helpful to readability.

Aaah. Srikar, sorry, I didn't notice this comment and I already
sent 1-15. But I added the blank line in 2/15 ;)

Ingo, please let me know if I need to re-diff and resend. Otherwise
I'll add the blank line later, write_opcode() needs more changes
anyway.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/