Re: [PATCH 09/14] i2c: Add Device Tree support to the Nomadik I2Cdriver

From: Lee Jones
Date: Thu Jun 14 2012 - 14:59:49 EST


On 14/06/12 19:46, Mark Brown wrote:
On Thu, Jun 14, 2012 at 07:36:36PM +0100, Mark Brown wrote:

You're not understanding Linus' point. The compatible string isn't
useful here because properties like the maximum clock rate of the bus
depend on the board design, not the silicon. The controller may be
perfectly happy to run at a given rate but other devices on the bus or
the electrical engineering of the PCB itself may restrict this further.

Sorry, I read the next revision and see this was actually resolved OK.

Yes, I just went ahead created the bindings anyway. I figured it would be neater (if no more functional) to keep all the variations in DT. Especially if we had devices which only varied by one or two settings, which would still require a complete new struct using the previous method.

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/