Re: [PATCH 14/14] staging/xgifb: Cleanup vb_device_info struct

From: Dan Carpenter
Date: Thu Jun 14 2012 - 07:51:19 EST


On Thu, Jun 14, 2012 at 01:07:47PM +0200, Peter Huewe wrote:
> Hi Dan,
> Thanks for the feedback.
> I agree somewhat with you that the patch is quite big and complex, that's why I added the seperators in the commit message, but when I created the patch it seemed logical enough (to me :) to keep it as one.
>
> Greg already pulled it in, but if you still want it split up I could do that for you -just let me know.
> However I'm not sure if then the smaller chunks should be merged or the big one.
>

No no. Forget about it. It's a blurry line which patches are too
complicated to do in one go. You got one through the gauntlet.
Next time you might not be so lucky. ;)

Btw, I think this series is great. I'm always in favour of deleting
code.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/