Re: [PATCH 09/17] i2c: omap: ack IRQ in parts

[Felipe Balbi]

On Thu, Jun 14, 2012 at 12:20:17PM +0100, Russell King - ARM Linux wrote:
> On Thu, Jun 14, 2012 at 01:20:42PM +0300, Felipe Balbi wrote:
> > According to flow diagrams on OMAP TRMs,
> > we should ACK the IRQ as they happen.
> 
> You don't explain that you're adding a new dev_err() statement into the
> driver for a missing acknowledge.
> 
> What if you're probing for a device - can this cause spam to the kernel
> console?  What if you have protocol mangling enabled with the "ignore
> lack of ack bit set" ?

indeed... maybe dev_vdbg() would fit better, or just don't add anything.

-- 
balbi

Attachment: signature.asc
Description: Digital signature