Re: [PATCH 02/13] code cleanup

From: Stefani Seibold
Date: Wed Jun 13 2012 - 14:00:13 EST


Am Dienstag, den 12.06.2012, 18:02 -0700 schrieb Greg KH:
> On Thu, Jun 07, 2012 at 10:20:32AM +0200, stefani@xxxxxxxxxxx wrote:
> > From: Stefani Seibold <stefani@xxxxxxxxxxx>
> >
> > - consistent nameing
> > - more compact style
> > - remove unneeded code
> >
> > Signed-off-by: Stefani Seibold <stefani@xxxxxxxxxxx>
> > ---
> > drivers/usb/usb-skeleton.c | 119 +++++++++++++++++---------------------------
> > 1 files changed, 46 insertions(+), 73 deletions(-)
>
> Your subject: needs to be fixed for all of these, as it does not
> describe what part of the kernel is being modified.
>
> A better example would be to use a prefix of:
> Subject: [PATCH XX/13] USB: skeleton:
> for all of these patches, so the shortlog entry is correct.
>
> Care to redo this series, based on the feedback you've gotten, and
> resend?
>

Yes, but i till take some time due my move to a new house.

Greetings,
Stefani


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/