Re: [PATCH 02/19] perf: Add ability to attach user level registersdump to sample

[Stephane Eranian]

On Wed, Jun 13, 2012 at 3:41 PM, Stephane Eranian <eranian@xxxxxxxxxx> wrote:
> On Wed, Jun 13, 2012 at 3:40 PM, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:
>> On Wed, 2012-06-13 at 15:18 +0200, Stephane Eranian wrote:
>>>
>>> If you look carefully at perf_output_sample(), you will notice that data is
>>> written in the exact order of the enum perf_event_sample_format.
>>
>> Not so actually.. CALLCHAIN is out of order. Not sure why we did that
>> though.
>>
>>
>> But it should match the comment near PERF_RECORD_SAMPLE.
>
> Ok, yes that one. It would have been much nicer to follow the enum
> order.
In that case, the comment needs to be update to show the sample_user_regs[]
in the right order.

         *      { u32                   size;
         *        char                  data[size];}&& PERF_SAMPLE_RAW
         *
         *      { u64 from, to, flags } lbr[nr];} && PERF_SAMPLE_BRANCH_STACK
         *      { u64 size; u64 regs[size];} && PERF_SAMPLE_USER_REGS

Same thing for the user stack.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/