Re: [PATCH RFT 3/4] regulator: wm831x-dcdc: Convert wm831x_buckv_opsto set_voltage_sel and map_voltage

From: Mark Brown
Date: Wed Jun 13 2012 - 06:03:39 EST


On Tue, Jun 12, 2012 at 10:23:09AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>

This patch is way more invasive than it needs to be (and therefore hard
to check) because

> - if (dcdc->dvs_gpio && dcdc->on_vsel == vsel)
> + if (dcdc->dvs_gpio && dcdc->on_vsel == selector)

you've replaced vsel with selector throughout the code.

Attachment: signature.asc
Description: Digital signature