Re: [PATCH v4] watchdog: Quiet down the boot messages

From: Ingo Molnar
Date: Wed Jun 13 2012 - 03:58:53 EST



* Don Zickus <dzickus@xxxxxxxxxx> wrote:

> After the change, it is simplified to:

> NMI watchdog enabled, takes one hw-pmu counter.

minor nit, the above line in the changelog does not match the
code anymore.

> + static unsigned long cpu0_err;

Please don't use statics inside functions - move it to file
scope, before the function or so.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/