Re: [PATCH V5 0/13] perf: Intel uncore pmu counting support

From: Ingo Molnar
Date: Wed Jun 13 2012 - 03:38:47 EST



* Stephane Eranian <eranian@xxxxxxxxxx> wrote:

> > Peter suggests keeping the uncore names as they're listed in
> > the intel doc. For Sandybirdge-EP, uncore names are
> > something like: Cbo, iMC, QPI. I think Uncore_Cbo_0 appears
> > better than uncore_Cbo_0
>
> Keeping the name is different from keeping the upper vs. lower
> case letters. I think this need to be case insensitive. What
> does it buy you to be case sensitive? Don't think Intel is
> ever going to create two events which differ only by the lower
> vs. upper case. And, I think that's extra frustration when you
> type the event name because you have to also remember the
> letter case.

Yeah - the right approach is to make it all lowercase in sysfs -
then user-space can tolower() the string provided by the user.

There should be no case sensitivity in event specifications
anywhere.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/