Re: [PATCH 1/7] drivers/ide/ide-cs.c: adjust suspicious bitoperation

From: David Miller
Date: Tue Jun 12 2012 - 18:52:13 EST


From: Julia Lawall <Julia.Lawall@xxxxxxx>
Date: Tue, 12 Jun 2012 10:17:25 -0400 (EDT)

> From: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> IO_DATA_PATH_WIDTH_8 is 0, so a bit-and with it is always false. The
> value IO_DATA_PATH_WIDTH covers the bits of the IO_DATA_PATH constants, so
> first pick those bits and then make the test using !=.
>
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/