Re: [PATCH v4 1/1] block: Add test-iosched scheduler

[Jeff Moyer]

merez@xxxxxxxxxxxxxx writes:

> On Tue, June 12, 2012 7:09 am, Jeff Moyer wrote:
>> Maya Erez <merez@xxxxxxxxxxxxxx> writes:
>>
>>> The test scheduler allows testing a block device by dispatching
>>> specific requests according to the test case and declare PASS/FAIL
>>> according to the requests completion error code
>>
>> What sort of tests have you written that make use of this
>> infrastructure?
>>
>>> @@ -1072,8 +1072,6 @@ struct request *blk_get_request(struct
>>> request_queue *q, int rw, gfp_t gfp_mask)
>>>  {
>>>  	struct request *rq;
>>>
>>> -	BUG_ON(rw != READ && rw != WRITE);
>>> -
>>
>> Please explain this.
> get_request and get_request_wait, called by blk_get_request, expects to
> get the REQ_SYNC flag in addition to the read/write flag. Moreover, it
> uses the REQ_SYNC flag in its algorithm decision making.
> However blk_get_request expects to get a Boolean to indicate only
> read/write flag and cannot handle the REQ_SYNC flag.

Right, so why is it okay to change this?  Right now, blk_get_request is
used for block special requests.  There is no sense of sync vs. async
for such requests (that's an fs request notion).  Perhaps you're calling
the wrong function?

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/