Re: [PATCH 1/2] pinctrl: pinctrl-mxs: Take care of frees if thekzalloc fails

From: Dong Aisheng
Date: Tue Jun 12 2012 - 07:52:29 EST


On Tue, Jun 12, 2012 at 01:31:25PM +0200, Linus Walleij wrote:
> On Sat, Jun 9, 2012 at 2:01 PM, Devendra Naga <devendra.aaru@xxxxxxxxx> wrote:
>
> > if there is no purecfg , the group pointer is allocated using kzalloc and if it
> > fails to allocate, we wont free the new_map,
> >
> > if config is true, we call kmemdup and if it
> > fails to do so we wont free the allocated group if there is no purecfg.
> >
> > fix this by doing the frees of new_map pointer and group pointers.
> >
> > Signed-off-by: Devendra Naga <devendra.aaru@xxxxxxxxx>
>
> Obviously correct so applied.
>
> Dong, Shawn: any ACKs?
>
Acked-by: Dong Aisheng <dong.aisheng@xxxxxxxxxx>

Regards
Dong Aisheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/