RE: [PATCH] staging: comedi: cleanup alloc_subdevices

[H Hartley Sweeten]

On Monday, June 11, 2012 5:44 PM, Greg KH wrote:
> On Mon, Jun 11, 2012 at 07:07:41PM -0500, H Hartley Sweeten wrote:
>> 2, 3, and 4 probably go together. They all deal with the 'num_subdevices'
>> 
>> 1 can be a separate patch as long as I don't do the rename.
>> 
>> 5, 6, and 7 could all go together with the final rename of the function.
>> 
>> Does that sound ok?
>
> No, why not just break it up into 7 different patches?  You are doing
> different things, which would you rather review for correctness, 7
> simple, tiny patches, or some that do multiple things at the same time
> that are bigger?

Ok. I just posted the first one. It's still pretty big since it hits every
comedi driver file.

Please ignore the first post. I fat-fingered the prototype in the header.
v2 is correct.

Also, I have never done local commits to my Linux-next tree so I'm not
sure how to proceed with the incremental patches. If it's ok with you
I'll just wait for each patch to go into staging.

Regards,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/