Re: [PATCH 2/2] ASoC: dmaengine-pcm: Add support for querying streamposition from DMA device

From: Mark Brown
Date: Mon Jun 11 2012 - 10:58:18 EST


On Mon, Jun 11, 2012 at 02:24:09PM +0100, Russell King - ARM Linux wrote:

> What we need to do is to get rid of this idea that reporting the residue
> is optional for DMA engine drivers. Let's make it absolutely required
> in order to support cyclic transfers.

I tend to agree, if we are going to let things not implement this we
need to provide an out of bounds way for them to signal that they don't
support it and make it an error to use the interface at all. Otherwise
the interface complexity increases as you get into special cases and so
on. We only need to fix the drivers that are used with ASoC immediately
and there's not so many of them which is easier than being forced to get
every driver upgraded at once.

Attachment: signature.asc
Description: Digital signature