Re: [PATCH] regulator: core: Return correct delay time in regulator_set_voltage_time_sel

[Yadwinder Singh Brar]

On Mon, Jun 11, 2012 at 10:44 AM, Axel Lin <axel.lin@xxxxxxxxx> wrote:
> rdev->desc->uV_step * abs(new_selector - old_selector) returns uV.
> The unit of ramp_delay is mV/us.
>
> Current code multiples 1000 at wrong place.
>

I am moving ramp_delay to constraints, so i have to modify this line again.
It will be corrected their.

Thanks,
Yadwinder.

> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
> ---
>  drivers/regulator/core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index f4c056a..63507a5 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -2308,7 +2308,7 @@ int regulator_set_voltage_time_sel(struct regulator_dev *rdev,
>        if (rdev->desc->ramp_delay && rdev->desc->uV_step)
>                return DIV_ROUND_UP(rdev->desc->uV_step *
>                        abs(new_selector - old_selector),
> -                       rdev->desc->ramp_delay) * 1000;
> +                       rdev->desc->ramp_delay * 1000);
>        return 0;
>  }
>
> --
> 1.7.9.5
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/